fix: create collision state

kkrt-labs · Sep 18, 2024 · 366770c · 366770c
1 parent 2c2d12a
commit 366770c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 30 deletions.
diff --git a/crates/evm/src/interpreter.cairo b/crates/evm/src/interpreter.cairo
@@ -19,8 +19,8 @@ use evm::instructions::{
 use evm::model::account::{AccountTrait};
 use evm::model::vm::{VM, VMTrait};
 use evm::model::{
-    Message, Environment, Transfer, ExecutionSummary, ExecutionSummaryTrait, ExecutionResult,
-    ExecutionResultTrait, ExecutionResultStatus, AddressTrait, TransactionResult, Address
+    Message, Environment, Transfer, ExecutionSummary, ExecutionResult, ExecutionResultTrait,
+    ExecutionResultStatus, AddressTrait, TransactionResult, Address
 };
 use evm::precompiles::Precompiles;
 use evm::precompiles::eth_precompile_addresses;
@@ -141,7 +141,7 @@ pub impl EVMImpl of EVMTrait {
         // };
 
         TransactionResult {
-            success: summary.is_success(),
+            success: summary.status == ExecutionResultStatus::Success,
             return_data: summary.return_data,
             gas_used: total_gas_used,
             state: summary.state,
@@ -156,9 +156,13 @@ pub impl EVMImpl of EVMTrait {
         let result = if is_deploy_tx {
             // Check collision
             if target_account.has_code_or_nonce() {
-                return ExecutionSummaryTrait::exceptional_failure(
-                    EVMError::DeployError(CONTRACT_ACCOUNT_EXISTS).to_bytes(),
-                );
+                return ExecutionSummary {
+                    status: ExecutionResultStatus::Exception,
+                    return_data: EVMError::DeployError(CONTRACT_ACCOUNT_EXISTS).to_bytes(),
+                    gas_left: 0,
+                    state: env.state,
+                    gas_refund: 0
+                };
             }
 
             let mut result = Self::process_create_message(message, ref env);

diff --git a/crates/evm/src/model.cairo b/crates/evm/src/model.cairo
@@ -108,30 +108,6 @@ pub struct ExecutionSummary {
     pub gas_refund: u64
 }
 
-#[generate_trait]
-pub impl ExecutionSummaryImpl of ExecutionSummaryTrait {
-    fn exceptional_failure(error: Span<u8>) -> ExecutionSummary {
-        ExecutionSummary {
-            status: ExecutionResultStatus::Exception,
-            return_data: error,
-            gas_left: 0,
-            state: Default::default(),
-            gas_refund: 0
-        }
-    }
-
-    fn is_success(self: @ExecutionSummary) -> bool {
-        *self.status == ExecutionResultStatus::Success
-    }
-
-    fn is_exception(self: @ExecutionSummary) -> bool {
-        *self.status == ExecutionResultStatus::Exception
-    }
-
-    fn is_revert(self: @ExecutionSummary) -> bool {
-        *self.status == ExecutionResultStatus::Revert
-    }
-}
 
 pub struct TransactionResult {
     pub success: bool,