Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: decode_legacy_tx for consistency with typed transactions #1012

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

ooochoche
Copy link
Contributor

@ooochoche ooochoche commented Oct 3, 2024

Refactor

Refactor decode_legacy_tx for consistency with typed transactions

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

The function has been splitted into two steps

  • Step 1: Decodes encoded_tx_data and returns the decoded data.
  • Step 2: Implements a trait in crates/utils/src/eth_transaction/transaction.cairo to decode transaction fields.

Resolves: #979

Refactor

  • Decodes transaction
  • Trait to decode transaction fields
  • Consistency with typed transactions eip2930.cairo

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat
Copy link
Collaborator

enitrat commented Oct 3, 2024

can you format?

@ooochoche
Copy link
Contributor Author

can you format?

I will do that now

@enitrat enitrat merged commit f6c15f5 into kkrt-labs:main Oct 4, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: refactor decode_legacy_tx for consistency with typed transactions
2 participants