Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/execution context update #384

Merged
merged 7 commits into from
Oct 2, 2023
Merged

Feat/execution context update #384

merged 7 commits into from
Oct 2, 2023

Conversation

Eikix
Copy link
Member

@Eikix Eikix commented Sep 28, 2023 •
edited
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #377

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

@Eikix Eikix force-pushed the feat/execution_context_update branch from f83f1bb to 8db5964 Compare September 28, 2023 10:03
Eikix
Eikix commented Sep 28, 2023
View reviewed changes
crates/evm/src/context.cairo Outdated Show resolved Hide resolved
Eikix
Eikix commented Sep 28, 2023
View reviewed changes
crates/evm/src/context.cairo Outdated Show resolved Hide resolved
enitrat
enitrat reviewed Oct 2, 2023
View reviewed changes
crates/evm/src/instructions/duplication_operations.cairo Show resolved Hide resolved
crates/evm/src/context.cairo Outdated Show resolved Hide resolved
crates/evm/src/context.cairo Show resolved Hide resolved
crates/evm/src/context.cairo Outdated Show resolved Hide resolved
crates/evm/src/context.cairo Outdated Show resolved Hide resolved
crates/evm/src/context.cairo Outdated Show resolved Hide resolved
crates/evm/src/machine.cairo Outdated Show resolved Hide resolved
enitrat
enitrat approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@enitrat enitrat added this pull request to the merge queue Oct 2, 2023
Merged via the queue into kkrt-labs:main with commit 9c220dd Oct 2, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enitrat enitrat enitrat approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: update the execution context and machine to match new design
2 participants
@Eikix @enitrat