fix: account state was discarded after processing created accounts initcode #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
changed the title
obatirou
reviewed
Aug 23, 2024
crates/evm/src/interpreter.cairo
Outdated
Comment on lines
66
to
68
| //@dev: Adding a scope block around `target_account` to ensure that the same instance is not | ||
| //being accessed after | ||
| // the state has been modified in `process_message`. |
There was a problem hiding this comment.
Suggested change
| //@dev: Adding a scope block around `target_account` to ensure that the same instance is not | |
| //being accessed after | |
| // the state has been modified in `process_message`. | |
| // @dev: Adding a scope block around `target_account` to ensure that the same instance is not | |
| // being accessed after the state has been modified in `process_message`. |
obatirou
reviewed
Aug 23, 2024
crates/evm/src/interpreter.cairo
Outdated
|
|
||
| let mut result = Self::process_message(message, ref env); | ||
|
|
||
| let target_account = env.state.get_account(target_evm_address); |
There was a problem hiding this comment.
put it next to its usage ?
just before match result.finalize_creation(target_account) {
obatirou
previously approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves: #
What is the new behavior?
target_accountand overriding any previous state changes.Does this introduce a breaking change?
This change is