Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add code address in message #901

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Sep 4, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #894

What is the new behavior?

  • Adds code_address in message struct
  • Execution of precompiles is done by checking code_address, not target_address (as we can delegatecall to a precompile...)
  • code_address is zero in case of deploy / create messages
  • had to adapt tests for delegatecall / callcade that were calling 0x100 (RIP7212 reserved address) to another, non-conflicting address

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat enitrat merged commit 4f774f6 into main Sep 4, 2024
4 checks passed
@enitrat enitrat deleted the feat/code-address-message branch September 4, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add code_address field in Message struct
1 participant