Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: returndata buffer emptied on stop #948

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Sep 16, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #

What is the new behavior?

  • Fixes an issue where the returndata buffer was not correctly emptied on stop.
  • Fixes an issue where the returndata was copied in memory for exceptional halts.
  • Adapted the CALL opcodes tests accordingly - no longer checking returndata, but rather checking the context in which an SSTORE was executed...

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat enitrat requested review from obatirou and removed request for ClementWalter September 16, 2024 16:16
@enitrat enitrat added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit cf6cfd4 Sep 17, 2024
4 checks passed
@enitrat enitrat deleted the fix/returndata-buffer-stop branch September 17, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants