Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: memory expansion cost could overflow #949

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: memory expansion cost could overflow #949

merged 1 commit into from
Sep 17, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Sep 16, 2024 •
edited
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #

What is the new behavior?

  • Fixes an issue where, given values high enough, offset + size could overflow
  • Used a Result to manage this issue.

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat enitrat mentioned this pull request Sep 17, 2024
Merged
9 tasks
@enitrat enitrat added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 08311ef Sep 17, 2024
4 checks passed
@enitrat enitrat deleted the fix/memory-expansion-overflow branch September 17, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obatirou obatirou obatirou approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enitrat @obatirou