Reimplement CLI using Click #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It currently implements the "auth", "scan" and "set-default" commands from the existing CLI, plus handles the config file centrally to make it easier for the sub-commands to work with. The new code is also fully typed.
|
I should perhaps mention that it in the current configuration gives pretty nice help output: and also |
|
@Tenzer y'know I spent about 2 days making this code work for me years ago when I needed it... Now I feel like I'm not really that involved anymore but to push a button :) Looks good btw, turning into a real thing not just a weekend hack like my repos usually are, which is sort of what I hoped for all along. |
This allows us to add custom logic, such as dynamically generating extra commands which will be needed for the LGTVRemote commands.
I incorrectly used `click.MultiCommand` instead of `click.Group`, although both works, but `click.MultiCommand` is being deprecated from the next Click version anyways. This also fixes a type annotation error since the `cls` argument to `@click.group()` only takes a `click.Group` class.
|
I've ended up instead working on a separate project from scratch which uses Typer as the CLI library, which is why there's been no more work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has felt awkward every time I've tried to add a new command to the CLI, and the current help output doesn't show all available sub-commands because the commands are handled in different ways depending on if they are part of
LGTVRemoteor not.To alleviate this situation, I tried to work on implementing the CLI using Click instead, and so far, I think it's been pretty good.
It currently implements the "auth", "scan", and "set-default" commands from the existing CLI, plus handles the config file centrally to make it easier for the sub-commands to work with.
The new code is also fully typed.
If this looks decent, I'll continue to work on getting the rest of the commands implemented. I'm thinking for the
LGTVRemoteandLGTVCursorcommands that, it might be easier to implement them programmatically via a dictionary lookup rather than having separate functions for each of them since the difference mainly is which URI the call results in.