Use staticfiles_storage to generate static files urls for widgets. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@klen any thoughts on this pr ? Also, I don't really know why Travis crashes during the coverage test (https://travis-ci.org/klen/django_markdown/jobs/86011076), any idea ? |
|
Same problem here I ended up creating my own |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Currently the urls for the widgets assets aren't processed by the project's defined static file storage (
STATICFILES_STORAGEin the settings) and so, when using a custom static file storage (like django-s3-storage), the generated urls results in 404.I sent these file paths through
django.contrib.staticfiles.storage.staticfiles_storage.urlto address this issue.This fixed a bug I had where the assets for the admin widget would point to
/admin/app/model/id/django_markdown/...instead ofhttps://s3-eu-west-1.amazonaws.com/bucket/static/django_markdown/...(I use S3 storage) and thus the widget would render as a simple textarea.