Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 2.0 #80

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Django 2.0 #80

wants to merge 2 commits into from

Conversation

Ge0
Copy link

@Ge0 Ge0 commented Dec 3, 2017

Hello there,

Django 2.0 has just been released and the django.core.urlresolvers submodule has been replaced by django.urls. This is a breaking change and we were warned about it since Django 1.7.

The following PR submit snippets that try to import urlresolvers first (for backward compatibility before Django 2.0) then, if it fails, imports django.urls for compatibility with new Django versions.

@seenureddy
Copy link

seenureddy commented Dec 20, 2017

@Ge0 This build is failed because of --use-mirrors has been deprecated.

@Ge0
Copy link
Author

Ge0 commented Dec 20, 2017

Oh, is this project alive eventually?

We should fix the CI then. :)

@seenureddy
Copy link

I have created the ticket #82 to fix this issue.

@tomasgarzon
Copy link

Hi, I'm upgrading my project to Django 2.0, are you planning a new release fixing this soon?

@Ge0
Copy link
Author

Ge0 commented Jan 10, 2018

I think we have to find another package...

@tomasgarzon
Copy link

any suggestion?

@Ge0
Copy link
Author

Ge0 commented Jan 10, 2018

Not that I have heard recently.

Also, you can still fork the repo, fix the bug and release a django2_markdown pip package. That would help a lot of people for sure, me included!

@tomasgarzon
Copy link

Great! I'll do it!

@Ge0
Copy link
Author

Ge0 commented Jan 10, 2018

Let me know here when it's done!

@Ge0
Copy link
Author

Ge0 commented Jan 10, 2018

@tomasgarzon Sorry for the delay, but have you taken a look at https://pypi.python.org/pypi/django-markdown-app ?

@tomasgarzon
Copy link

Yes, but it doesn't have django 2.0 support, have the same problem with django.core.urlresolvers

@tomasgarzon
Copy link

Sorry, It has support but you should use pip install from git directly.

@Ge0
Copy link
Author

Ge0 commented Jan 11, 2018

Oh I see. Maybe this project is maintained compare to django_markdown.

@seenureddy
Copy link

@Ge0 https://github.com/seenureddy/django_markdown fix and merge the broken Travis. Create the PR to the repo?

@Ge0
Copy link
Author

Ge0 commented Mar 9, 2018

This repository is abandoned, not sure there is something to do.

@abdulwahid24
Copy link

@Ge0 I see you have updated the fork with Django2.0 here https://github.com/Ge0/django-markdown-gcir. I am thinking to use it because I can't go for other packages as I am working on a legacy project which is required to migrate into Django 2.0+.

I hope there won't be any issue using https://github.com/Ge0/django-markdown-gcir.
Please do let me know your thoughts.

Thanks

@Ge0
Copy link
Author

Ge0 commented Jul 5, 2019

Hey @abdulwahid24

It has been a while since I last used this package. I cannot guarantee that there won’t be any issue at this time.

You’ll might have to modify the package to make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants