Merge pull request #1828 from kleros/chore/appeal-loading-skeleton

chore: appeal tab improve loading
kleros · Jan 13, 2025 · 6f21310 · 6f21310
2 parents e27997b + 9456601
commit 6f21310
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 19 deletions.
diff --git a/web/src/components/Popup/MiniGuides/PageContentsTemplate.tsx b/web/src/components/Popup/MiniGuides/PageContentsTemplate.tsx
@@ -24,6 +24,7 @@ export const LeftContentContainer = styled.div`
 
 export const StyledImage = styled.div`
   width: ${responsiveSize(260, 460)};
+
   ${landscapeStyle(
     () => css`
       width: 389px;

diff --git a/web/src/pages/Cases/CaseDetails/Appeal/AppealHistory.tsx b/web/src/pages/Cases/CaseDetails/Appeal/AppealHistory.tsx
@@ -1,14 +1,15 @@
 import React from "react";
 import styled from "styled-components";
 
+import Skeleton from "react-loading-skeleton";
+
 import { useOptionsContext, useFundingContext } from "hooks/useClassicAppealContext";
 
 import HowItWorks from "components/HowItWorks";
 import Appeal from "components/Popup/MiniGuides/Appeal";
 
 import OptionCard from "./OptionCard";
-
-import { AppealHeader, StyledTitle } from ".";
+import { AppealHeader, StyledTitle } from "./index";
 
 const OptionsContainer = styled.div`
   display: grid;
@@ -26,7 +27,7 @@ const AppealHistory: React.FC<IAppealHistory> = ({ isAppealMiniGuideOpen, toggle
   const options = useOptionsContext();
   const { winningChoice, paidFees, fundedChoices } = useFundingContext();
 
-  return (
+  return options && options.length > 2 ? (
     <div>
       <AppealHeader>
         <StyledTitle>Appeal Results - Last Round</StyledTitle>
@@ -37,24 +38,20 @@ const AppealHistory: React.FC<IAppealHistory> = ({ isAppealMiniGuideOpen, toggle
         />
       </AppealHeader>
       <OptionsContainer>
-        {options ? (
-          options.map((option, index) => {
-            return (
-              <OptionCard
-                key={option + index}
-                text={option}
-                winner={index.toString() === winningChoice}
-                funding={BigInt(paidFees?.[index] ?? "0")}
-                required={fundedChoices?.includes(index.toString()) ? BigInt(paidFees?.[index] ?? "0") : undefined}
-                canBeSelected={false}
-              />
-            );
-          })
-        ) : (
-          <h2>Not in appeal period</h2>
-        )}
+        {options.map((option, index) => (
+          <OptionCard
+            key={option + index}
+            text={option}
+            winner={index.toString() === winningChoice}
+            funding={BigInt(paidFees?.[index] ?? "0")}
+            required={fundedChoices?.includes(index.toString()) ? BigInt(paidFees?.[index] ?? "0") : undefined}
+            canBeSelected={false}
+          />
+        ))}
       </OptionsContainer>
     </div>
+  ) : (
+    <Skeleton />
   );
 };
 export default AppealHistory;