Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I wondered whether this worked with EF5 too, added strong name keyfile #3

Open
wants to merge 75 commits into
base: master
Choose a base branch
from

Conversation

Atrejoe
Copy link

@Atrejoe Atrejoe commented Oct 22, 2012

Upgraded EF (to 5)
Upgraded NUnit
Added strong name key file

@kgreed
Copy link

kgreed commented Jan 27, 2013

I cant get migrations working because I no longer have a class inheriting direcly from DbContext

@Atrejoe
Copy link
Author

Atrejoe commented Jan 28, 2013

Sorry, can't help you out there, I don't have experience with migrations yet.

@kgreed
Copy link

kgreed commented Jan 28, 2013

The first step seems to be to make the HookedDbContext class not be abstract.
I can then run add-migration at Package Manager console, however the migrations created don't contain changes ... perhaps because the migration would be looking at the wrong Context to work them out. After that... getting them to run may contain similar issues

@visoft
Copy link

visoft commented May 27, 2013

@kgreed -

Migrations work fine with my branch of EFHooks. I've published my own package of EFHooks to Nuget if you want to try it out. I didn't want to push my own package, but sadly, @kmckelvin hasn't been keeping up the the project. I needed to use EFHooks in multiple projects, so I ended up creating a separate package. Anyway, It's based on EF5 and supports .NET 4 and 4.5. http://nuget.org/packages/VisoftInc.EFHooks/. You can read a little more about it on my blog.

@Atrejoe -

Unfortunately I didn't see your pull request before making changes to my fork. I'd be interested to know the the VisoftInc.EFHooks NuGet package works for your projects. I'm actively maintaining VisoftInc.EFHooks, so feel free to make changes in my branch and I'll make sure they get pushed to NuGet.

@Atrejoe
Copy link
Author

Atrejoe commented May 27, 2013

Hi Damian,

I am afk right now, but might look into the code tomorrow or wednesday. It would be cool if we could keep this alive. @kmckelvin contacted me a few months ago, asking me to take over to which I agreed. Unfortunately I think he's a bit busy.

It would be nice if we could merge our changes and keep the NuGet centralized and up to date.

----- Reply message -----
From: "Damien White" [email protected]
To: "kmckelvin/EFHooks" [email protected]
Cc: "Robert Sirre" [email protected]
Subject: [EFHooks] I wondered whether this worked with EF5 too, added strong name keyfile (#3)
Date: Mon, May 27, 2013 16:06
@kgreed -

Migrations work fine with my branch of EFHooks. I've published my own package of EFHooks to Nuget if you want to try it out. I didn't want to push my own package, but sadly, @kmckelvin hasn't been keeping up the the project. I needed to use EFHooks in multiple projects, so I ended up creating a separate package. Anyway, It's based on EF5 and supports .NET 4 and 4.5. http://nuget.org/packages/VisoftInc.EFHooks/. You can read a little more about it on my blog.

@Atrejoe -

Unfortunately I didn't see your pull request before making changes to my fork. I'd be interested to know the the VisoftInc.EFHooks NuGet package works for your projects. I'm actively maintaining VisoftInc.EFHooks, so feel free to make changes in my branch and I'll make sure they get pushed to NuGet.


Reply to this email directly or view it on GitHub.

@visoft
Copy link

visoft commented May 28, 2013

@Atrejoe -

I just submitted a pull request with my changes. I'm perfectly fine with keeping one branch/package alive. I just needed to use a more up-to-date version of EFHooks on multiple projects and I didn't want to copy code all over the place.

Atrejoe added 2 commits May 28, 2013 22:21
Conflicts:
	.gitignore
	EFHooks.Tests/App.config
	EFHooks.Tests/EFHooks.Tests.csproj
	EFHooks.Tests/HookedDbContextTests.cs
	EFHooks.Tests/packages.config
	EFHooks/App.config
	EFHooks/EFHooks.csproj
	EFHooks/HookEntityMetadata.cs
	EFHooks/HookedDbContext.cs
	EFHooks/packages.config
Added pack batch file
@Atrejoe
Copy link
Author

Atrejoe commented May 28, 2013

I merge your pull request with my branch. Can you check whether you agree on my merges? I liked you methods of compiling the same source files by referencing them in another project. A simple trick, but I never thought of this.

As requested by Kelvin I published the Nuget package here.
http://nuget.org/packages/Atreyu.EFHooks/

The unit tests work, however I have yet to the the stuff in my development environment.

@Atrejoe
Copy link
Author

Atrejoe commented May 28, 2013

@kmckelvin, by the way, it might be better if we transfer the repository ownership after the three of us agree.
https://help.github.com/articles/how-to-transfer-a-repository

Atrejoe and others added 30 commits December 3, 2013 21:38
Fixed unit test error in wrapped connection that was brought to light by new hooking functionality.
…king

fix to error when mocking hookeddbcontext
(ignored packages marked as published too)
All constructors will actually add hooks
…to make calling `AttachHooks` dependant on wether the particular overload was called or not. (I don't like idle instantiation)

Made overload call base instead of another overload to prevent calling `ListenToObjectMaterialized` twice or in incorrect order.
Published v2.3.1.0
…d to investigate), Corrected NuGet version to be three digit (irrelevant)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants