Allow users to download songs #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for downloading songs in three different formats:
The module that converts UG tabs to ChordPro is self-contained (in
chordpro.py). I've used this patch for a couple of months now and ironed out most of its bugs - I can confirm that it works well for almost all of the songs I've tried. The ChordPro format is supported by multiple open-source programs and phone apps, and the officialchordprotool allows creating pretty PDF songbooks from collections of ChordPro files, and also stuff like transposing for piano and different notations.I'm guessing that the plain text export would also be useful for a number of people who want to just be able to quickly view songs offline.
I've tried to keep the changes to the freetar UI as minimal as possible, and I'm open to any modification suggestions.