Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support to load static files from subdir #1914

Merged
merged 5 commits into from
Aug 1, 2024
Merged

Conversation

kmuto
Copy link
Owner

@kmuto kmuto commented Jul 30, 2024

#1913 の対応

まずはEPUBMakerの対応から。

@kmuto
Copy link
Owner Author

kmuto commented Jul 30, 2024

MiniMagick::Tool::Compare.new(whiny: false)

が使えなくなった模様?

ビルダはあとはweb, text, idgxml

@kmuto
Copy link
Owner Author

kmuto commented Jul 31, 2024

  • MiniMagickの新しい書き方に追従した
  • webはもともとパスから直下にコピーするようにしているので修正不要
  • textはstaticファイルコピーなし、修正不要
  • idgxmlはstaticファイルコピーなし、修正不要

@kmuto kmuto changed the title WIP: support to load static files from subdir support to load static files from subdir Jul 31, 2024
@kmuto kmuto requested a review from kdmsnr July 31, 2024 14:57
@kmuto
Copy link
Owner Author

kmuto commented Jul 31, 2024

@kdmsnr
#1913 についてサブフォルダから直下にコピーして置くようにしてみました。
レビューいただけますでしょうか?

@kdmsnr
Copy link
Collaborator

kdmsnr commented Jul 31, 2024

よさそうでした。実質 copy_static_file の最初の1行を追加するだけでよかったんですね。

Copy link
Collaborator

@kdmsnr kdmsnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmuto kmuto merged commit b070710 into master Aug 1, 2024
17 checks passed
@kmuto kmuto deleted the staticfiles-in-subdir branch August 1, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants