Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The api version should match the broker config apiversion #5597

Merged
merged 1 commit into from
Jul 18, 2023
Merged

The api version should match the broker config apiversion #5597

merged 1 commit into from
Jul 18, 2023

Conversation

akesiraju
Copy link
Contributor

No description provided.

@knative-prow knative-prow bot requested a review from nainaz June 8, 2023 20:26
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@knative-prow knative-prow bot requested a review from pierDipi June 8, 2023 20:26
@netlify
Copy link

netlify bot commented Jun 8, 2023 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a774be3
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/64b5a86ba3f699000784cee5
😎 Deploy Preview https://deploy-preview-5597--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow
Copy link

knative-prow bot commented Jun 8, 2023

Welcome @akesiraju! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 8, 2023
@dprotaso
Copy link
Member

dprotaso commented Jun 8, 2023

Thanks @akesiraju you'll want to sign our CLA - details here #5597 (comment)

/assign @gabo1208

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2023
@gabo1208
Copy link
Member

gabo1208 commented Jun 9, 2023

Thank you very much @akesiraju !! Approved cc @dprotaso

@dprotaso
Copy link
Member

dprotaso commented Jun 9, 2023

/approve

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2023
@akesiraju
Copy link
Contributor Author

Anything else I should do to merge this PR

@gabo1208
Copy link
Member

gabo1208 commented Jun 11, 2023 •
edited
Loading

Do you fixed the CLA? If you did push an empty commit for the CI to recognize the fix

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 12, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: matzew / name: Matthias Wessendorf (a774be3)

@gabo1208
Copy link
Member

@akesiraju https://confluence.linuxfoundation.org/pages/viewpage.action?pageId=86641302 here it says how to fix it, try that and if you have any troubles following that ping me over the knative slack :). (sorry for all the CLA mumbo jumbo, but it's part of the OSS mojo hehe 😓 )

@dprotaso dprotaso mentioned this pull request Jun 15, 2023
Closed
@skonto
Copy link
Contributor

skonto commented Jul 13, 2023

@akesiraju gentle ping. Could you fix the CLA issue so we can merge this?

@matzew @akesiraju
Using workloads instead of deployments on the documentation (knative#…
a774be3 
…5596)

Signed-off-by: Matthias Wessendorf <[email protected]>

The api version should match the broker config apiversion

Empty-Commit

The api version should match the broker config apiversion
@akesiraju akesiraju force-pushed the fix_typo_rabbitmq_broker_example branch from affd75d to a774be3 Compare July 17, 2023 20:45
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2023
ReToCode
ReToCode approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akesiraju, dprotaso, gabo1208, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 08f355a into knative:main Jul 18, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabo1208 gabo1208 gabo1208 approved these changes

@ReToCode ReToCode ReToCode approved these changes

@nainaz nainaz Awaiting requested review from nainaz

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@gabo1208 gabo1208

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@akesiraju @dprotaso @gabo1208 @skonto @ReToCode @matzew