Add details for storage and knative services #5605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
knative-prow
bot
added
the
size/M
dprotaso
reviewed
Jun 22, 2023
docs/serving/services/storage.md
Outdated
Comment on lines
3
to
5
| Knative Serving integrates with K8s storage capabilities via supporting a subset of ephemeral storage volumes and via PersistentVolumeClaims(PVCs) volume types. | ||
| In detail Knative Serving supports emptyDir by default, secret, configmap, projection and PVCs volume types. | ||
| For more details on volume configuration check the related [feature flags](../configuration/feature-flags.md) when applicable. |
There was a problem hiding this comment.
Suggested change
| Knative Serving integrates with K8s storage capabilities via supporting a subset of ephemeral storage volumes and via PersistentVolumeClaims(PVCs) volume types. | |
| In detail Knative Serving supports emptyDir by default, secret, configmap, projection and PVCs volume types. | |
| For more details on volume configuration check the related [feature flags](../configuration/feature-flags.md) when applicable. | |
| By default Serving supports the mounting the [volume types](https://kubernetes.io/docs/concepts/storage/volumes):`emptyDir`, `secret`, `configMap` and `projected`. [PersistentVolumes](https://kubernetes.io/docs/concepts/storage/persistent-volumes/) are supported but require a [feature flag](../configuration/feature-flags.md) to be enabled. |
docs/serving/services/storage.md
Outdated
| In detail Knative Serving supports emptyDir by default, secret, configmap, projection and PVCs volume types. | ||
| For more details on volume configuration check the related [feature flags](../configuration/feature-flags.md) when applicable. | ||
|
|
||
| Here is an example of using PVCs: |
There was a problem hiding this comment.
Suggested change
| Here is an example of using PVCs: | |
| Here is an example of using a persistent volume claim with a Knative Service: |
docs/serving/services/storage.md
Outdated
Comment on lines
40
to
41
| The example assumes that the user has enabled PVC support via the corresponding feature flag. | ||
|
|
There was a problem hiding this comment.
Can drop this since we mention it above
Suggested change
| The example assumes that the user has enabled PVC support via the corresponding feature flag. |
docs/serving/services/storage.md
Outdated
Comment on lines
42
to
43
| !!! warning | ||
| Mounting large volumes may add considerable overhead to the application's start up time. |
There was a problem hiding this comment.
I'd consider moving this before the example
config/nav.yml
Outdated
| @@ -131,6 +131,7 @@ nav: | |||
| # TODO: Add security section to docs? | |||
| - Configure resource requests and limits: serving/services/configure-requests-limits-services.md | |||
| - HTTPS redirection: serving/services/http-protocol.md | |||
| - Configuring storage: serving/services/storage.md | |||
There was a problem hiding this comment.
Suggested change
| - Configuring storage: serving/services/storage.md | |
| - Volume Support: serving/services/storage.md |
knative-prow
bot
added
the
approved
|
@dprotaso thanks, comments addressed. |
|
@dprotaso gentle ping. |
add missing whitespace
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes