Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting started blog p2 #5636

Merged
merged 20 commits into from
Sep 18, 2023
Merged

Getting started blog p2 #5636

merged 20 commits into from
Sep 18, 2023

Conversation

Cali0707
Copy link
Member

This PR is the second full post in the getting started blog series, and focuses on how to set up your environment

Cali0707 and others added 3 commits July 21, 2023 16:25
@Cali0707
Wrote article contents
7640a3e
@Cali0707 @Leo6Leo
Added images to post
947d8c4 
Signed-off-by: Calum Murray <[email protected]>
Co-authored-by: Leo Li <[email protected]>
@Cali0707
Put images into post
4100494 
Signed-off-by: Calum Murray <[email protected]>
@netlify
Copy link

netlify bot commented Jul 21, 2023 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a809324
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/64f88c6319f08b00084544b5
😎 Deploy Preview https://deploy-preview-5636--knative.netlify.app/blog/articles/getting-started-blog-p2
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 21, 2023
@knative-prow knative-prow bot requested review from csantanapr and snneji July 21, 2023 20:39
@Leo6Leo
Copy link
Member

Leo6Leo commented Jul 21, 2023

/cc @Leo6Leo

@knative-prow knative-prow bot requested a review from Leo6Leo July 21, 2023 20:40
@Cali0707
Copy link
Member Author

/assign @Leo6Leo
/cc @aliok @creydr @pierDipi @lberk @debasishbsws

@Cali0707
Added article to site nav
a1437bd 
Signed-off-by: Calum Murray <[email protected]>
creydr
creydr reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great that you're working on this 👍
Left a few review comments

blog/docs/articles/getting-started-blog-p2.md Outdated Show resolved Hide resolved
blog/docs/articles/getting-started-blog-p2.md Outdated Show resolved Hide resolved
blog/docs/articles/getting-started-blog-p2.md Outdated Show resolved Hide resolved
blog/docs/articles/getting-started-blog-p2.md Outdated Show resolved Hide resolved
blog/docs/articles/getting-started-blog-p2.md Outdated Show resolved Hide resolved
blog/docs/articles/getting-started-blog-p2.md Outdated Show resolved Hide resolved
blog/docs/articles/getting-started-blog-p2.md Outdated Show resolved Hide resolved
blog/docs/articles/getting-started-blog-p2.md Outdated Show resolved Hide resolved
blog/docs/articles/getting-started-blog-p2.md Outdated Show resolved Hide resolved
blog/docs/articles/getting-started-blog-p2.md Show resolved Hide resolved
@Cali0707 Cali0707 requested a review from creydr July 24, 2023 18:04
@Cali0707
Copy link
Member Author

@creydr I think I have addressed all your review comments... let me know if I missed anything!

Leo6Leo
Leo6Leo suggested changes Jul 24, 2023
View reviewed changes
blog/docs/images/getting-started-blog-series/post2/jb002.png Outdated Show resolved Hide resolved
blog/docs/articles/getting-started-blog-p2.md Outdated Show resolved Hide resolved
blog/docs/articles/getting-started-blog-p2.md Outdated Show resolved Hide resolved
blog/docs/articles/getting-started-blog-p2.md Outdated Show resolved Hide resolved
blog/docs/articles/getting-started-blog-p2.md Outdated Show resolved Hide resolved
blog/docs/articles/getting-started-blog-p2.md Outdated Show resolved Hide resolved
blog/docs/articles/getting-started-blog-p2.md Outdated Show resolved Hide resolved
blog/docs/articles/getting-started-blog-p2.md Outdated Show resolved Hide resolved
blog/docs/articles/getting-started-blog-p2.md Outdated Show resolved Hide resolved
blog/docs/articles/getting-started-blog-p2.md Outdated Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2023
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 3, 2023
@Leo6Leo
Copy link
Member

Leo6Leo commented Aug 14, 2023

/cc @aliok

@knative-prow knative-prow bot requested a review from aliok August 14, 2023 13:00
@creydr
Copy link
Member

creydr commented Sep 5, 2023

/lgtm
from my side

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
@Cali0707
Add missing period
2a7e1be 
Signed-off-by: Calum Murray <[email protected]>
@Leo6Leo
Copy link
Member

Leo6Leo commented Sep 5, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
@Cali0707
fixing typos
a809324 
Signed-off-by: Calum Murray <[email protected]>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2023
@Cali0707 Cali0707 requested a review from lberk September 6, 2023 14:27
creydr
creydr reviewed Sep 13, 2023
View reviewed changes
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side. Thanks a lot for this @Cali0707 and @Leo6Leo
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2023
pierDipi
pierDipi approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@knative-prow
Copy link

knative-prow bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2023
@knative-prow knative-prow bot merged commit 8b10c28 into knative:main Sep 18, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr creydr left review comments

@krsna-m krsna-m krsna-m left review comments

@pierDipi pierDipi pierDipi approved these changes

@csantanapr csantanapr Awaiting requested review from csantanapr

@snneji snneji Awaiting requested review from snneji

@debasishbsws debasishbsws Awaiting requested review from debasishbsws

@matzew matzew Awaiting requested review from matzew

@aliok aliok Awaiting requested review from aliok

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

@lberk lberk Awaiting requested review from lberk

Assignees

@creydr creydr

@pierDipi pierDipi

@Leo6Leo Leo6Leo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Cali0707 @Leo6Leo @creydr @aliok @lberk @pierDipi @krsna-m @knative-prow-robot