-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding blog on Knative Vision #5638
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
||
Knative defines an EventType API which allows for discovery of the types of events that are available in the Knative Eventing system. This helps developers understand what kinds of events can be listened to and processed, which can be particularly helpful in systems with a large number of events being produced. | ||
|
||
However currently the EventType is unfortunately underused and is limited to Source-Duck compliant sources, in combination with the Knative Broker API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any links to "Source-Duck compliant sources" ? I guess only 5-6 people will get what this means in the entire world :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it is a fact, since that auto-create only works under some rules.
Any suggestion to say this differently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something like
"However currently the EventType is unfortunately underused and is limited to sources which are compliant with / implement the Knative Source Ducktype, in combination with the Knative Broker API"
|
||
### Authorization and admission policies | ||
|
||
Event-driven architecture is meant to lower organizations' silos and barriers, make systems more resilient and ultimately increase business agility, however, this is not possible without event admission policies and safeguards for security and data quality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the other sections have a section about what the current state is. Wanna write something similar?
Even if that we don't have anything, and brokers+channels+etc will simply accept any events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pierDipi can you take a look here?
I think it is a good suggestion by Ali
I like it overall. Some diagrams would have been great, although that's a lot of work. Thanks for putting it together |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thanks for providing this.
Overall seems LGTM so far
|
||
For more information, please refer to the [feature track document](https://docs.google.com/document/d/1H-x_oji8LqkCyd7tlsSyclmUe7FAmEJPgRxOU_0pkn8/edit). | ||
|
||
### Sender identity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only wondering if "Authentication" would be a better heading, as it's more often referenced 🤔
But of course, only personal opinionated...
For more detailed information, please refer to | ||
the [transport-encryption feature](https://github.com/knative/docs/pull/5642) | ||
|
||
/* TODO use real feature docs link once PR above is in */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a TODO after #5642
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold |
/unhold |
the [transport-encryption feature](https://github.com/knative/docs/pull/5642) | ||
|
||
/* TODO use real feature docs link once PR above is in */ | ||
the [transport-encryption feature](https://knative.dev/docs/eventing/experimental-features/transport-encryption/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a relative file link here, not absolute URLs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've always used actual links for pointers to documentation 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link is not working in preview, but I think its, because you didn't rebase after #5642 merged.
/lgtm
/hold
to give others a chance to review too. Otherwise unhold...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even the eventtype-auto-creation feature documentation is not working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why tho, perhaps let's just go with direct links?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The blog and the docs are technically two different builds, so relative links won't work across them... in the nav, you need to use something like /docs/eventing/experimental...
, but I don't recall offhand if that also works from the docs themselves
(there's some more info on the setup at https://github.com/knative/docs/tree/main/blog#docsblogconfignavyml)
Signed-off-by: Matthias Wessendorf <[email protected]>
Co-authored-by: Christoph Stäbler <[email protected]>
Co-authored-by: Christoph Stäbler <[email protected]>
Co-authored-by: Christoph Stäbler <[email protected]>
Co-authored-by: Christoph Stäbler <[email protected]>
Co-authored-by: Christoph Stäbler <[email protected]>
Co-authored-by: Christoph Stäbler <[email protected]>
Co-authored-by: Christoph Stäbler <[email protected]>
Co-authored-by: Christoph Stäbler <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
I've rebased and again updated it. @psschwei that |
Signed-off-by: Matthias Wessendorf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good from a docs perspective
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/unhold |
Proposed Changes