Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename knative-sandbox to knative-extensions #5652

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Rename knative-sandbox to knative-extensions #5652

merged 1 commit into from
Aug 3, 2023

Conversation

davidhadas
Copy link
Contributor

This is an automated PR to replace knative-sandbox strings to knative-extensions.

@netlify
Copy link

netlify bot commented Aug 2, 2023 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c4371bf
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/64ca13909466e70007a95725
😎 Deploy Preview https://deploy-preview-5652--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 2, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Aug 3, 2023

/hold
knative/func#1899 is causing issues for func.
Don't want to merge anything else until that is sorted to save us resources and time if a rename revert is necessary.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
upodroid
upodroid approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fixing func shouldn't block this PR.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@krsna-m krsna-m removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Aug 3, 2023

/approve

@knative-prow
Copy link

knative-prow bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidhadas, kvmware, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
@knative-prow knative-prow bot merged commit da2c5ff into knative:main Aug 3, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@matzew matzew Awaiting requested review from matzew

@nainaz nainaz Awaiting requested review from nainaz

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidhadas @krsna-m @upodroid