Skip to content

Commit

Permalink
webhooks need to specify sideEffects (#2410)
Browse files Browse the repository at this point in the history
  • Loading branch information
lberk authored and knative-prow-robot committed Jan 21, 2020
1 parent 294a1c1 commit 8a92a8c
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions config/500-webhook-configuration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ webhooks:
name: eventing-webhook
namespace: knative-eventing
failurePolicy: Fail
sideEffects: None
name: webhook.eventing.knative.dev
---
apiVersion: admissionregistration.k8s.io/v1beta1
Expand All @@ -42,6 +43,7 @@ webhooks:
name: eventing-webhook
namespace: knative-eventing
failurePolicy: Fail
sideEffects: None
name: validation.webhook.eventing.knative.dev
---
apiVersion: admissionregistration.k8s.io/v1beta1
Expand All @@ -58,6 +60,7 @@ webhooks:
name: eventing-webhook
namespace: knative-eventing
failurePolicy: Fail
sideEffects: None
name: config.webhook.eventing.knative.dev
namespaceSelector:
matchExpressions:
Expand All @@ -78,6 +81,7 @@ webhooks:
name: eventing-webhook
namespace: knative-eventing
failurePolicy: Fail
sideEffects: None
name: sinkbindings.webhook.sources.knative.dev
---
apiVersion: admissionregistration.k8s.io/v1beta1
Expand All @@ -94,6 +98,7 @@ webhooks:
name: eventing-webhook
namespace: knative-eventing
failurePolicy: Fail
sideEffects: None
name: legacysinkbindings.webhook.sources.knative.dev
---
apiVersion: v1
Expand Down

0 comments on commit 8a92a8c

Please sign in to comment.