Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependabot and auto hack scripts #830

Closed
wants to merge 1 commit into from
Closed

Add dependabot and auto hack scripts #830

wants to merge 1 commit into from

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Jul 31, 2023

As per title, this patch adds dependabot.

/cc @kvmware @dprotaso

@knative-prow knative-prow bot requested review from dprotaso and krsna-m July 31, 2023 07:27
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 31, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f25e82a) 82.84% compared to head (4a5cc23) 82.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #830   +/-   ##
=======================================
  Coverage   82.84%   82.84%           
=======================================
  Files          45       45           
  Lines        1708     1708           
=======================================
  Hits         1415     1415           
  Misses        252      252           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nak3
Copy link
Contributor Author

nak3 commented Aug 7, 2023

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2023
@@ -0,0 +1,38 @@
name: dependabot - hack scripts
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added to either actions or .github repo so that we can just sync the file across repos. Not everyone uses dependabot but there are a few that do and would benefit from it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I was hesitated to adding the common dependabot because some repo has their own dependabot like https://github.com/knative-extensions/eventing-kafka-broker/blob/main/.github/workflows/build-dependabot-pr.yaml
But I will add it to the common one.

@krsna-m
Copy link

krsna-m commented Aug 7, 2023

We already merged this dependabot workflow and it is my bad for not mentioning this then. However, we should generalize this and move it to actions or .github so others can take advantage.

@nak3 nak3 closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants