Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup SAN constants and Secrets Keys for system-internal-tls certificates #861

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Cleanup SAN constants and Secrets Keys for system-internal-tls certificates #861

merged 2 commits into from
Oct 2, 2023

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Sep 18, 2023 •
edited
Loading

Changes

See knative/serving#14392 (comment)

/kind cleanup

Partially knative/serving#14392

@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 18, 2023
@ReToCode
Copy link
Member Author

Basically the same applies for CI as in #858 (comment).
We are half-using this this stuff and half-not using this stuff, so it's a bit hard to clean it up without breaking.

/assign @nak3
/assign @KauzClay
/assign @dprotaso

@codecov
Copy link

codecov bot commented Sep 18, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (50368a7) 82.26% compared to head (c32d156) 82.22%.
Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #861      +/-   ##
==========================================
- Coverage   82.26%   82.22%   -0.05%     
==========================================
  Files          45       45              
  Lines        1720     1716       -4     
==========================================
- Hits         1415     1411       -4     
  Misses        264      264              
  Partials       41       41
Files Coverage Δ
pkg/certificates/reconciler/certificates.go 66.94% <100.00%> (-1.09%) ⬇️
pkg/certificates/reconciler/controller.go 92.85% <ø> (ø)
pkg/certificates/reconciler/controller_impl.go 62.50% <ø> (ø)
pkg/certificates/reconciler/reconciler.go 30.08% <ø> (ø)
pkg/config/config.go 79.79% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReToCode
Copy link
Member Author

Ah, forget the comment about CI. Seems we did not even us any of those flags just yet.

@ReToCode ReToCode changed the title Cleanup knative-internal-tls constants and secrets Cleanup system-internal-tls constants and secrets Sep 22, 2023
@ReToCode ReToCode changed the title Cleanup system-internal-tls constants and secrets Cleanup SAN constants and Secrets Keys for system-internal-tls certificates Sep 22, 2023
dprotaso
dprotaso reviewed Sep 25, 2023
View reviewed changes
pkg/certificates/constants.go
// Deprecated: FakeDnsName is deprecated.
// Please use the DataPlaneRoutingSAN for calls to the Activator
// and the DataPlaneUserSAN function for calls to a Knative-Service via Queue-Proxy.
FakeDnsName = LegacyFakeDnsName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FakeDnsName = LegacyFakeDnsName
FakeDNSName = LegacyFakeDnsName

Technically we should be casing this properly

and a bunch of other properties below

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but these are already used in this form.
If we want to fix that, we probably need to create more reverse compatible deprecated fields.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we're going to drop this field soon

@dprotaso
Copy link
Member

dprotaso commented Oct 2, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2023
@knative-prow knative-prow bot merged commit 463dc38 into knative:main Oct 2, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso dprotaso left review comments

@krsna-m krsna-m Awaiting requested review from krsna-m

@xtreme-vikram-yadav xtreme-vikram-yadav Awaiting requested review from xtreme-vikram-yadav

Assignees

@dprotaso dprotaso

@nak3 nak3

@KauzClay KauzClay

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ReToCode @dprotaso @nak3 @KauzClay