Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unused reconciler and certs code #919

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

ReToCode
Copy link
Member

Changes

  • Clean up unused reconciler and certs code
  • Only Serving was using those, they are no longer needed

/kind cleanup

Fixes #893
Fixes #864

@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 30, 2024
@knative-prow knative-prow bot requested review from krsna-m and skonto January 30, 2024 06:30
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bdf2c51) 82.23% compared to head (4742247) 94.03%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #919       +/-   ##
===========================================
+ Coverage   82.23%   94.03%   +11.79%     
===========================================
  Files          46       42        -4     
  Lines        1751     1307      -444     
===========================================
- Hits         1440     1229      -211     
+ Misses        268       65      -203     
+ Partials       43       13       -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReToCode
Copy link
Member Author

/assign @dprotaso
/assign @skonto

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2024
Copy link

knative-prow bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 060ef7a into knative:main Jan 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
3 participants