[main] Upgrade to latest dependencies

[knative-automation]

Cron -knative-prow-robot

/cc knative/serving-writers knative/eventing-writers
/assign knative/serving-writers knative/eventing-writers

Produced by: knative-extensions/knobots/actions/update-deps

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.06% ⚠️

Comparison is base (9780686) 81.84% compared to head (526dfb4) 81.78%.

❗ Current head 526dfb4 differs from pull request most recent head 5e2a8f1. Consider uploading reports for the commit 5e2a8f1 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2810      +/-   ##
==========================================
- Coverage   81.84%   81.78%   -0.06%     
==========================================
  Files         167      167              
  Lines       10217    10217              
==========================================
- Hits         8362     8356       -6     
- Misses       1610     1614       +4     
- Partials      245      247       +2     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dprotaso]

@cardil rather than an env var why don't we just infer repos want to use vendor if they already have a vendor folder?

This would mean things should just work as expected until repos remove vendor themselves?

[dprotaso]

Another question are we skipping update_licenses call if there is no vendor? If so why?

[cardil]

It already works like you're suggesting.

If you don't have a vendor dir, it will not be created for you. If you have one, it will be updated as it was before. You could set this environment flag to force the creation of vendor dir, which I imagine being handy for Knative's vendors.

The license saving is removed here, yes, if there's no vendor dir. But, remember we still do the license scan during the --build-test run. I believe that satisfies the CNCF license guidelines AFAIK.

[dprotaso]

The license saving is removed here, yes, if there's no vendor dir. But, remember we still do the license scan during the --build-test run. I believe that satisfies the CNCF license guidelines AFAIK.

We ship licenses in our containers - we shouldn't stop doing that unless we get clear guidance from the CNCF that we no longer need to do that

[dprotaso]

So I would expect we still run even if we don't have a vendor folder

update_licenses third_party/VENDOR-LICENSE "./..."

[dprotaso]

/hold

/assign @cardil to answer questions

[dprotaso]

Unholding - created a separate issue knative/hack#315
/unhold
/lgtm
/apporve

[dprotaso]

/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-automation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment