drop special logic when handling kubelet probe header for istio mTLS

[izabelacg]

Changes

• Deprecates k-kubelet-probe header

Part of knative/serving#14981

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.70%. Comparing base (fd7cc21) to head (5844df8).
Report is 43 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2997      +/-   ##
==========================================
- Coverage   78.70%   78.70%   -0.01%     
==========================================
  Files         188      188              
  Lines       11051    11050       -1     
==========================================
- Hits         8698     8697       -1     
  Misses       2090     2090              
  Partials      263      263              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dprotaso]

This is a breaking change and not something we want.

The serving issue is about removing the bit of code where we set the header on the deployment readiness/liveness etc.

The kubelet that does the proxying still adds this user agent so we still need to handle them accordingly.

[dprotaso]

Circling back - I misread the PR (early morning reviews are bad for me)

The changes in the PR are good but I think we should merge them after the deployment changes have been around for a release. So this should land for 1.15

See details here: knative/networking#950 (comment)

/hold

[dprotaso]

/retest
/unhold

[dprotaso]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dprotaso]

/retest
unrelated failure

{Failed  === RUN   TestNamespaceStream
    stream_test.go:316: Log was still produced, trying again...
    stream_test.go:323: No watching should have happened context canceled
--- FAIL: TestNamespaceStream (0.41s)
}