Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonise release leads table & roster #260

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

ReToCode
Copy link
Member

Changes

  • Add client & functions column to release leads

I think we should have client & functions also on this table, as you folks are always also a part of the release.

/assign @dsimansk

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 31, 2023
@ReToCode
Copy link
Member Author

Questions about the roster:

  • @evankanderson @lionelvillard do you folks want to stay on the Eventing release roster?
  • @rhuss do you want to stay on the client release roster?
  • @lkingland could you ask in your WG who would like to be added for functions?

@dsimansk
Copy link
Contributor

I think we should have client & functions also on this table, as you folks are always also a part of the release.

I see the motivation here. However, as far as I remember we (client) were always carried by the appointed release leads from either Serving or Eventing WGs. Hence there are no more special release steps for Client, plugins or Functions repositories.

I wonder if we really need the split to WG groups per historical context. Or we should merge pools of available release leads (I assume usually WG leads apply here) and pick the rotation from a single one.

I would like to discuss it with TOC as well. If there are any opinions.

/cc @knative/technical-oversight-committee

@knative-prow knative-prow bot requested a review from a team October 31, 2023 10:42
@ReToCode
Copy link
Member Author

I wonder if we really need the split to WG groups per historical context. Or we should merge pools of available release leads (I assume usually WG leads apply here) and pick the rotation from a single one.

I think that is a very good point and I like your proposal.

@psschwei
Copy link
Contributor

If I remember right, part of the rationale for having someone from Serving and Eventing on the release was in case there were Serving- or Eventing-specific issues that popped up, for example, something in the autoscaler that would be difficult for someone not familiar with Serving to fix.

Not sure how often those kinds of issues are still occurring (if at all), but assuming someone from the WG could be available at some point to assist if/when those types of things pop up, then I could see not needing them to be a formal release lead...

@dprotaso
Copy link
Member

There's an issue here discussion this point: #32

tl;dr we just need a roster of folks to help shepherd the release. Any issues with particular repos should then require the release leads to pull in the respective WG leads to help. eg. test is flaking etc.

@ReToCode
Copy link
Member Author

ReToCode commented Nov 2, 2023

So assuming, that in the future we'll only have one or two release leads shepherding the release and folks from the respective WGs joining to take care of their repos.

I updated the PR to reflect:

  • The currently still active members of the release rotation
  • Updated the table to have only one column for release leads

WDYT?

@evankanderson
Copy link
Member

I'm willing to stay on a rotation; historically (when this was started) there was a bit of unsteadiness in the releases that I think has been ironed out since.

@ReToCode ReToCode changed the title Add client & functions to release leads Harmonise release leads table & rooster Nov 2, 2023
@ReToCode ReToCode changed the title Harmonise release leads table & rooster Harmonise release leads table & roster Nov 2, 2023
@dprotaso
Copy link
Member

dprotaso commented Nov 2, 2023

/lgtm
/approve

Copy link

knative-prow bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2023
@knative-prow knative-prow bot merged commit 4b32e3e into knative:main Nov 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants