stop the certWatcher using defer

knative · Aug 30, 2023 · 218c1bf · 218c1bf
1 parent 99ae0c1
commit 218c1bf
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/pkg/queue/sharedmain/main.go b/pkg/queue/sharedmain/main.go
@@ -259,6 +259,7 @@ func Main(opts ...Option) error {
 		if err != nil {
 			logger.Fatal("failed to create certWatcher", zap.Error(err))
 		}
+		defer certWatcher.Stop()
 
 		// Drop admin http server since the admin TLS server is listening on the same port
 		delete(httpServers, "admin")
@@ -315,10 +316,6 @@ func Main(opts ...Option) error {
 			}
 		}
 
-		if certWatcher != nil {
-			certWatcher.Stop()
-		}
-
 		logger.Info("Shutdown complete, exiting...")
 	}
 	return nil