Add PullIfNotPresent to multiple container test

knative · Aug 31, 2023 · 5fe9ce8 · 5fe9ce8
1 parent cea3201
commit 5fe9ce8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/test/conformance/api/v1/service_test.go b/test/conformance/api/v1/service_test.go
@@ -724,6 +724,12 @@ func TestServiceCreateWithMultipleContainers(t *testing.T) {
 		Image: pkgtest.ImagePath(names.Sidecars[0]),
 	}}
 
+	// Please see the comment in test/v1/configuration.go.
+	if !test.ServingFlags.DisableOptionalAPI {
+		containers[0].ImagePullPolicy = corev1.PullIfNotPresent
+		containers[1].ImagePullPolicy = corev1.PullIfNotPresent
+	}
+
 	// Setup initial Service
 	if _, err := v1test.CreateServiceReady(t, clients, &names, func(svc *v1.Service) {
 		svc.Spec.Template.Spec.Containers = containers

diff --git a/test/e2e/multicontainer_test.go b/test/e2e/multicontainer_test.go
@@ -57,6 +57,12 @@ func TestMultiContainer(t *testing.T) {
 		Image: pkgTest.ImagePath(names.Sidecars[0]),
 	}}
 
+	// Please see the comment in test/v1/configuration.go.
+	if !test.ServingFlags.DisableOptionalAPI {
+		containers[0].ImagePullPolicy = corev1.PullIfNotPresent
+		containers[1].ImagePullPolicy = corev1.PullIfNotPresent
+	}
+
 	test.EnsureTearDown(t, clients, &names)
 	t.Log("Creating a new Service")