-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add security_mode metric tag to request metrics #14265
Add security_mode metric tag to request metrics #14265
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: KauzClay The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #14265 +/- ##
========================================
Coverage 86.26% 86.26%
========================================
Files 195 199 +4
Lines 14702 14827 +125
========================================
+ Hits 12683 12791 +108
- Misses 1719 1734 +15
- Partials 300 302 +2
☔ View full report in Codecov by Sentry. |
b8c94ae
to
0fc6863
Compare
* based on security mode from config in context
* security mode set as env var based on config from reconciler
0fc6863
to
b6e8c10
Compare
Based on this comment it seems like we'd go for the request logging approach |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
yup, I'll close this and get started on a different PR for doing it via logs |
Fixes #
In support of: #14092
Relies on: knative/networking#842
Proposed Changes
Release Note