Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update performance tests #14288

Closed
wants to merge 2 commits into from
Closed

Conversation

ReToCode
Copy link
Member

/hold testing only - for now

@knative-prow knative-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 22, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ReToCode
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Aug 22, 2023
@ReToCode
Copy link
Member Author

/test performance-tests-mako

@knative-prow
Copy link

knative-prow bot commented Aug 22, 2023

@ReToCode: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
performance-tests-mako_serving_main 157c004 link false /test performance-tests-mako

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (587de3d) 86.25% compared to head (157c004) 86.23%.

❗ Current head 157c004 differs from pull request most recent head 19afb45. Consider uploading reports for the commit 19afb45 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14288      +/-   ##
==========================================
- Coverage   86.25%   86.23%   -0.03%     
==========================================
  Files         195      195              
  Lines       14702    14702              
==========================================
- Hits        12681    12678       -3     
- Misses       1721     1723       +2     
- Partials      300      301       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReToCode ReToCode closed this Aug 22, 2023
@ReToCode ReToCode reopened this Aug 22, 2023
@ReToCode ReToCode closed this Aug 22, 2023
SetUseGZip(true).
SetBatchSize(20).
//nolint:gosec // We explicitly don't need to check certs here since this is test code.
SetTLSConfig(&tls.Config{InsecureSkipVerify: true}))

Check failure

Code scanning / CodeQL

Disabled TLS certificate check High test

InsecureSkipVerify should not be used in production code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant