Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update net-certmanager nightly #14314

Merged

Conversation

knative-automation
Copy link
Contributor

/assign @knative/serving-writers
/cc @knative/serving-writers

Produced via:

for x in net-certmanager.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-certmanager/latest/$x > ${GITHUB_WORKSPACE}/./third_party/cert-manager-latest/$x
done

Details:

bumping knative.dev/net-certmanager 1717ad2...4f78867:
  > 4f78867 upgrade to latest dependencies (# 576)

bumping knative.dev/net-certmanager 1717ad2...4f78867:
  > 4f78867 upgrade to latest dependencies (# 576)

Signed-off-by: Knative Automation <[email protected]>
@knative-prow knative-prow bot requested a review from a team August 30, 2023 11:05
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/networking labels Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04% 🎉

Comparison is base (323b8c9) 86.19% compared to head (6ba50aa) 86.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14314      +/-   ##
==========================================
+ Coverage   86.19%   86.23%   +0.04%     
==========================================
  Files         195      195              
  Lines       14704    14704              
==========================================
+ Hits        12674    12680       +6     
+ Misses       1728     1724       -4     
+ Partials      302      300       -2     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow
Copy link

knative-prow bot commented Aug 30, 2023

@knative-automation: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
https_serving_main 6ba50aa link false /test https

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-automation, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2023
@knative-prow knative-prow bot merged commit a2ef52b into knative:main Aug 30, 2023
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants