Fix broken links to kubernetes docs on reference page

[JinVei]

Proposed Changes

Knative serving-api reference page has some broken links to kubernetes docs. Just try to fix it.

Release Note

NONE

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: JinVei (f857fef)

[knative-prow]

Welcome @JinVei! It looks like this is your first PR to knative/serving 🎉

[knative-prow]

Hi @JinVei. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dprotaso]

These docs are autogenerated using this script

serving/hack/update-reference-docs.sh

Line 32 in 17c3012

-out-file "docs/serving-api.md" \

which uses this tool https://github.com/ahmetb/gen-crd-api-reference-docs

I wonder if the tool should be bumped?

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (fb6997c) 86.11% compared to head (f857fef) 86.10%.
Report is 10 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14340      +/-   ##
==========================================
- Coverage   86.11%   86.10%   -0.01%     
==========================================
  Files         196      196              
  Lines       14781    14781              
==========================================
- Hits        12728    12727       -1     
  Misses       1747     1747              
- Partials      306      307       +1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nak3]

The version v1.21 is defined in our template hack/reference-docs-gen-config.json so I think this PR LGTM.

If we will bump the tool's version, @JinVei could you please bump it? I think you can bump the version with the following command:

$ source vendor/knative.dev/hack/library.sh
$ go_update_deps --upgrade --domain  github.com/ahmetb

[JinVei]

The version v1.21 is defined in our template hack/reference-docs-gen-config.json so I think this PR LGTM.

If we will bump the tool's version, @JinVei could you please bump it? I think you can bump the version with the following command:

$ source vendor/knative.dev/hack/library.sh
$ go_update_deps --upgrade --domain  github.com/ahmetb

Sure, i can do it.
Should i bump the tool's version in this PR? It seems like it also makes a lot of changes to the code in k8s.io/klog/v2 and k8s.io/gengo.

[krsna-m]

I think as long as it is in a different commit it should be fine

[dprotaso]

based on @nak3's comment you can probably skip updating the tool and instead update the config here: https://github.com/knative/serving/blob/main/hack/reference-docs-gen-config.json

[JinVei]

based on @nak3's comment you can probably skip updating the tool and instead update the config here: https://github.com/knative/serving/blob/main/hack/reference-docs-gen-config.json

Yes, I have replaced kubernetes-api/v1.21 with kubernetes-api/v1.28 in reference-docs-gen-config.json, and renew serving-api.md by running this script update-reference-docs.sh.

[nak3]

/lgtm
/approve

Thank you @JinVei !

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinVei, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nak3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment