-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sec context and resources for performance jobs #14529
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14529 +/- ##
=======================================
Coverage 86.01% 86.02%
=======================================
Files 197 197
Lines 14915 14915
=======================================
+ Hits 12829 12830 +1
Misses 1776 1776
+ Partials 310 309 -1 ☔ View full report in Codecov by Sentry. |
runAsNonRoot: true | ||
capabilities: | ||
drop: | ||
- ALL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably want to keep the ---
to avoid the GH lint warning.
/test performance-tests |
I guess this doesn't have those assertions about rate - should we merge this after you address Reto's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proposed Changes