Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sec context and resources for performance jobs #14529

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Oct 17, 2023

Proposed Changes

  • Fixes the sec context
  • Constraints the resources used to avoid variance

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Oct 17, 2023
@skonto skonto changed the title Fix sec context for performance jobs Fix sec context and resources for performance jobs Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (39ee6f7) 86.01% compared to head (6c870da) 86.02%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14529   +/-   ##
=======================================
  Coverage   86.01%   86.02%           
=======================================
  Files         197      197           
  Lines       14915    14915           
=======================================
+ Hits        12829    12830    +1     
  Misses       1776     1776           
+ Partials      310      309    -1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

runAsNonRoot: true
capabilities:
drop:
- ALL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to keep the --- to avoid the GH lint warning.

@dprotaso
Copy link
Member

/test performance-tests

@dprotaso
Copy link
Member

I guess this doesn't have those assertions about rate - should we merge this after you address Reto's nit and then re-run the test in the other PR here - #14429 ?

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 9896079 into knative:main Oct 19, 2023
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants