Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove special logic for user-agent header with istio mtls #15034

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

izabelacg
Copy link
Member

Changes

  • Remove logic that adds a custom header (k-kubelet-probe) in requests coming from kubelet with istio mtls

Fixes #14981

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/API API objects and controllers labels Mar 25, 2024
@knative-prow knative-prow bot requested review from ReToCode and skonto March 25, 2024 19:35
@knative-prow knative-prow bot added area/autoscale area/networking size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.06%. Comparing base (932ef55) to head (dd4e973).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15034      +/-   ##
==========================================
- Coverage   84.07%   84.06%   -0.02%     
==========================================
  Files         213      213              
  Lines       16796    16776      -20     
==========================================
- Hits        14121    14102      -19     
- Misses       2320     2322       +2     
+ Partials      355      352       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@izabelacg
Copy link
Member Author

/restest

@izabelacg
Copy link
Member Author

The following PR has the required changes also in networking, pkg and net-istio: #15011. The only failed tests in that PR are tests that currently fail in main as well.

@izabelacg izabelacg changed the title [WIP] remove special logic for user-agent header with istio mtls remove special logic for user-agent header with istio mtls Mar 25, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2024
@izabelacg
Copy link
Member Author

/retest

@izabelacg
Copy link
Member Author

/retest

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
Copy link

knative-prow bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@knative-prow knative-prow bot merged commit 0ad570f into knative:main Mar 27, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify and drop special User-Agent handling logic for Istio
2 participants