Fix configuration metadata inconsistency

[skonto]

Fixes #15594

Proposed Changes

• Sorts routes list for the serving.knative.dev/routes anno to avoid triggering non-required reconciliations.
• I benchmarked different sorting options:
  a) sets.List(valSet) <- this sorts the set behind the scenes.
  b)

   set := valSet.UnsortedList() 
   sort.Strings(set)
  

I think the overhead is low but b) seems ~10% faster. For a small number of routes, the common case, the diff is negligible (sorting is trivial), does not matter if a) or b) is used.

Release Note

Fixes a problem in configuration reconciliation where labeler creates a different order of the route names listed via the annotation `serving.knative.dev/routes` compared to the configuration reconciler.

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.50%. Comparing base (c8e131b) to head (0bc5f1a).
Report is 32 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/reconciler/labeler/accessors.go	50.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15601      +/-   ##
==========================================
- Coverage   84.49%   83.50%   -0.99%     
==========================================
  Files         219      219              
  Lines       13608    17427    +3819     
==========================================
+ Hits        11498    14553    +3055     
- Misses       1740     2501     +761     
- Partials      370      373       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ReToCode]

hm here it is not yet sorted, right? so maybe call that variable routes or something like that?

[skonto]

yeah it is going to be sorted :) I can change it.

[ReToCode]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ReToCode,skonto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment