fix: update popperjs dependency #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1ccb6be The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thomaswhyyou
approved these changes
Jan 31, 2024
| @@ -46,6 +46,7 @@ | |||
| "dependencies": { | |||
| "@knocklabs/client": "*", | |||
| "@knocklabs/react-core": "*", | |||
| "@popperjs/core": "^2.11.8", | |||
There was a problem hiding this comment.
Guessing this is a peer dependency of react-popper?
There was a problem hiding this comment.
Yeah, it's a peer dependency in react-popper, but we also use it for types in NotificationFeedPopover.tsx. Not sure why it being missing didn't break the build. Issue only surfaced when there was a conflict with a user's app which also had react-popper installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing popperjs import