Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add testing set up and base coverage for React SDKs #41

Merged

Conversation

connorlindsey
Copy link
Contributor

@connorlindsey connorlindsey commented Jan 31, 2024

Sets up Vitest and testing-library for react and react-core with a few base test cases.

Holding off on react native as Vitest doesn't support it. There are some workarounds we could consider like rendering using react-native-web during testing or using Jest. vitest-dev/vitest#1321

Copy link

changeset-bot bot commented Jan 31, 2024

⚠️ No Changeset found

Latest commit: 58673ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@connorlindsey connorlindsey marked this pull request as ready for review January 31, 2024 21:32
Copy link
Member

@kylemcd kylemcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! test-utils helper is great too!

@connorlindsey connorlindsey merged commit 1c7026d into main Jan 31, 2024
1 check passed
@connorlindsey connorlindsey deleted the connor-kno-5089-react-sdks-add-test-suite-and-base-coverage branch January 31, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants