Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix goreleaser configuration #30

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

ngehrsitz
Copy link
Contributor

Description of changes:
This fixes the broken goreleaser configuration and will allow publishing new versions. Uptaking Go 1.21 as build version was also necessary because of goreleaser/goreleaser#2066.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Comment on lines +40 to +54
file_name_template: >-
{{- .ProjectName }}_
{{- .Version }}_
{{- if eq .Os "darwin" }}macOS
{{- else if eq .Os "linux" }}Linux
{{- else if eq .Os "openbsd" }}OpenBSD
{{- else if eq .Os "netbsd" }}NetBSD
{{- else if eq .Os "freebsd" }}FreeBSD
{{- else if eq .Os "dragonfly" }}DragonFlyBSD
{{- else }}{{ .Os }}{{ end }}-
{{- if eq .Arch "amd64" }}64bit
{{- else if eq .Arch "386" }}32bit
{{- else if eq .Arch "arm" }}ARM
{{- else if eq .Arch "arm64" }}ARM64
{{- else }}{{ .Arch }}{{ end }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This keeps compatibility with the previous format, see: https://github.com/ngehrsitz/cob/releases/tag/v0.0.8
Not sure if the complexity is worth it though.

@ngehrsitz
Copy link
Contributor Author

ngehrsitz commented Oct 13, 2023

This depends on #28 being merged first because the golangci-lint version in this branch is too old for 1.21

@knqyf263
Copy link
Owner

Looks good, but the linting test is failing.

@ngehrsitz
Copy link
Contributor Author

I rebased and it should work now.

@ngehrsitz
Copy link
Contributor Author

Since you auto-approve dependabot PRs you probably want to configure the Lint and Test Checks as required in your branch protection rule. This should then make auto-merge available.
image

uses: goreleaser/goreleaser-action@v5
with:
distribution: goreleaser
version: v1.21.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opted to pin this version since goreleaser appears to be introducing breaking changes somewhat frequently https://goreleaser.com/deprecations/

@knqyf263 knqyf263 merged commit 9ae8ddb into knqyf263:master Oct 16, 2023
3 checks passed
@knqyf263
Copy link
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants