-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Go to 1.22 #64
Conversation
1f28fd8
to
feb0eed
Compare
Thanks for your contribution.
xerrors.Errorf is not deprecated. |
Rephrased :) |
I mean it's needed for stack trace. |
If I understand correctly you want to use the stack backtrace that xerrors provides? I see the Go team removed the deprecation notice. I guess I can drop that change if you prefer. Wonder if it really adds any value - there's not that much special that can go wrong here. |
I'm curious why you're wondering. There are many cases where it fails and stack trace can help. |
In this project the scope is so limited - it is running two commands and compare results. Good error handling and logging should IMO negate the introduction of a new dependency to inspect a stack. But, I can tell you are convinced it adds value, so I'll remove the change from the PR |
feb0eed
to
c93e25b
Compare
c93e25b
to
4c59b0c
Compare
I don't mind if you want to delete it, but it is not because it is deprecated and it should be made clear that there is a price to pay for losing stack traces. In other words, it is better to do it in another PR if you want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description of changes:
This PR:
This PR does not introduce any breaking changes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.