Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies. #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update dependencies. #9

wants to merge 1 commit into from

Conversation

knz
Copy link
Owner

@knz knz commented Jun 13, 2023

No description provided.

@knz knz force-pushed the 20230613-update-deps branch 7 times, most recently from e5fe550 to 1234359 Compare June 13, 2023 08:40
@knz knz force-pushed the 20230613-update-deps branch from 1234359 to bdf416c Compare June 13, 2023 08:41
jelischer
jelischer reviewed Jun 13, 2023
View reviewed changes
Copy link

@jelischer jelischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to address the failures I have seen

@knz
Copy link
Owner Author

knz commented Jun 14, 2023

It appears to but what this really does in uncover a new bug in bubbles/lipgloss that wasn't there before. I'm in touch with the charm folk to get this fixed there instead of here.

@jelischer
Copy link

Do you have any idea of a timescale?
As you said, the failure here is just local and I'm evaluating just importing it as it is and commenting out the unit tests. so that our automatic tests don't revert the import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelischer jelischer jelischer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knz @jelischer