Update OpenAIEncoder to latest OpenAI client
#112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koaning
approved these changes
Jan 18, 2025
|
Oh! And one question actually, is there a reason why you're using these embeddings instead of their open-source counterparts? |
|
Not really, I was just experimenting with all kinds of different embeddings. However, at work we use OpenAI embeddings (and completion models) through Azure a lot. So for me it would be nice to maybe have an |
|
I would be open to having it listed here if you feel like making another PR. I probably won't use it much myself but if it helps you it's enough of an argument for me to host it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR that updates the
OpenAIEncoderto the latest OpenAI client.#111