Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Remove attachments without deleting submissions #4984

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

Feature: Remove attachments without deleting submissions #4984

wants to merge 31 commits into from

Commits on Jun 24, 2024

  1. create AttachmentActionsDropdown component 

    WIP
    @magicznyleszek
    magicznyleszek committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    6bf51b5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'task-810-replace-deprecated-buttons' into feature/delet… 

    …e-attachment
    @magicznyleszek
    magicznyleszek committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    122588b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/delete-attachment' into feature_delete-attachme… 

    …nt_task-671_delete-button
    @magicznyleszek
    magicznyleszek committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    2c5faed View commit details
    Browse the repository at this point in the history

  4. cleanup data table audio player cell styles

    @magicznyleszek
    magicznyleszek committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    d04cedb View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. cleanup KoboSelect option styles

    @magicznyleszek
    magicznyleszek committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    4b82d6e View commit details
    Browse the repository at this point in the history

  2. cleanup KoboModal default size

    @magicznyleszek
    magicznyleszek committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    41792be View commit details
    Browse the repository at this point in the history

  3. disable deleting in AttachmentActionsDropdown if insufficient permiss… 

    …ions
    @magicznyleszek
    magicznyleszek committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    2a63146 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'beta' into feature/delete-attachment

    @magicznyleszek
    magicznyleszek committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    170e4ad View commit details
    Browse the repository at this point in the history

  5. Merge branch 'feature/delete-attachment' into feature_delete-attachme… 

    …nt_task-671_delete-button
    @magicznyleszek
    magicznyleszek committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1e7e2c8 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. fix bg audio url flow in the modal

    @magicznyleszek
    magicznyleszek committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    9688352 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Merge branch 'beta' into feature/delete-attachment

    @magicznyleszek
    magicznyleszek committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    41372f9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/delete-attachment' into feature_delete-attachme… 

    …nt_task-671_delete-button
    @magicznyleszek
    magicznyleszek committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    835ff2f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'beta' into feature/delete-attachment

    @magicznyleszek
    magicznyleszek committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    0c32b6e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/delete-attachment' into feature_delete-attachme… 

    …nt_task-671_delete-button
    @magicznyleszek
    magicznyleszek committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    1a30fc1 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. use better permissions checking in AttachmentActionsDropdown 

    and add some TODO comments
    @magicznyleszek
    magicznyleszek committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    fee53d3 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Merge branch 'cleanup-submission-modal' into feature/delete-attachment

    @magicznyleszek
    magicznyleszek committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    191f798 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/delete-attachment' into feature_delete-attachme… 

    …nt_task-671_delete-button

# Conflicts:
#	jsapp/js/components/submissions/submissionDataTable.tsx
#	jsapp/js/components/submissions/submissionModal.tsx
    @magicznyleszek
    magicznyleszek committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7642be8 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Merge branch 'beta' into feature/delete-attachment

    @magicznyleszek
    magicznyleszek committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    fb1dc83 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/delete-attachment' into feature_delete-attachme… 

    …nt_task-671_delete-button
    @magicznyleszek
    magicznyleszek committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    dc74df1 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Merge branch 'beta' into feature/delete-attachment

    @magicznyleszek
    magicznyleszek committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    5cd305b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/delete-attachment' into feature_delete-attachme… 

    …nt_task-671_delete-button
    @magicznyleszek
    magicznyleszek committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    f4b75c5 View commit details
    Browse the repository at this point in the history

  3. post merge fixes

    @magicznyleszek
    magicznyleszek committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    2365f3c View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. handle is_deleted attachments properly (WIP)

    @magicznyleszek
    magicznyleszek committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    a5eb006 View commit details
    Browse the repository at this point in the history

  2. add is_deleted flag to interface

    @magicznyleszek
    magicznyleszek committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f76eb20 View commit details
    Browse the repository at this point in the history

  3. add missing imports

    @magicznyleszek
    magicznyleszek committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    3352d8b View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Merge branch 'beta' into feature/delete-attachment

    @magicznyleszek
    magicznyleszek committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    5c79d58 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/delete-attachment' into feature_delete-attachme… 

    …nt_task-671_delete-button

# Conflicts:
#	jsapp/js/components/formGallery/formGallery.component.tsx
    @magicznyleszek
    magicznyleszek committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    01964f9 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. use proper permission

    @magicznyleszek
    magicznyleszek authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    409ca97 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Merge pull request #4995 from kobotoolbox/feature_delete-attachment_t… 

    …ask-671_delete-button

[TASK-671] [TASK-558] Reusable delete attachment dropdown
    @jamesrkiger
    jamesrkiger authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    1f3e375 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Merge branch 'beta' into feature/delete-attachment 

    # Conflicts:
#	jsapp/js/components/common/koboSelect.scss
#	jsapp/js/components/submissions/submissionModal.tsx
    @magicznyleszek
    magicznyleszek committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    55c71c7 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Merge branch 'main' into feature/delete-attachment 

    # Conflicts:
#	jsapp/js/components/common/koboSelect.scss
#	jsapp/js/components/processing/sidebar/sidebarSubmissionMedia.module.scss
#	jsapp/js/components/submissions/submissionDataTable.tsx
#	jsapp/js/components/submissions/submissionModal.tsx
    @magicznyleszek
    magicznyleszek committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    ce92a82 View commit details
    Browse the repository at this point in the history