Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(organizations): add badge to profile dropdown TASK-979 #5253

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

duvld
Copy link
Member

@duvld duvld commented Nov 11, 2024

🗒️ Checklist

  1. run linter locally
  2. update all related docs (API, README, inline, etc.), if any
  3. draft PR with a title <type>(<scope>)<!>: <title> TASK-1234
  4. tag PR: at least frontend or backend unless it's global
  5. fill in the template below and delete template comments
  6. review thyself: read the diff and repro the preview as written
  7. open PR & confirm that CI passes
  8. request reviewers, if needed
  9. delete this section before merging

📣 Summary

Add the organization badge to the profile dropdown.

📖 Description

Tiny reshuffle of elements to make it match the designs.

👀 Preview steps

  1. Have an MMO with some users in it
  2. Ensure the feature flag mmosEnabled is true
  3. While logged in with a user in an MMO, clicking the profile icon should show the organization badge (in blue) under the user's email

@duvld duvld self-assigned this Nov 11, 2024
@jnm jnm added the Front end label Nov 11, 2024
@jamesrkiger jamesrkiger changed the title feat(organizations): Add badge to profile dropdown feat(organizations): add badge to profile dropdown TASK-979 Nov 11, 2024
Copy link

width: fit-content;
}

.header {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the only thing we are changing based on where this component is being used is color, let's just have the component take 'badgeColor' as a prop. That way if someone ends up using a light blue org badge elsewhere in the app they won't need to make a new class for it.

@magicznyleszek magicznyleszek removed their request for review November 14, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants