-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brings DNSControl up to date along with some new features #118
base: main
Are you sure you want to change the base?
Conversation
grep -v -e '\.\.\. (skipping)' |\ | ||
grep -v -e '^----- DNS Provider: ' |\ | ||
grep -v -e '^----- Registrar: ' |\ | ||
grep -v -e '^----- Getting nameservers from:' | ||
grep -v -e '^----- Getting nameservers from:' | \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The grep -v
statements can be removed. Those are only output if the --full
flag is used, which it isn't.
@@ -6,4 +6,6 @@ grep -v -e '^\.\.\.0 corrections$' |\ | |||
grep -v -e '\.\.\. (skipping)' |\ | |||
grep -v -e '^----- DNS Provider: ' |\ | |||
grep -v -e '^----- Registrar: ' |\ | |||
grep -v -e '^----- Getting nameservers from:' | |||
grep -v -e '^----- Getting nameservers from:' | \ | |||
sed -r "s/\x1B\[([0-9]{1,3}(;[0-9]{1,2};?)?)?[mGK]//g" # remove ANSI color codes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of the sed, you can use ``--no-color` (it goes before the "preview" or "push" verb).
I would also add:
--reportmax=0
-- be less verbose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I implemented it like this was so that colors still worked in the action log, but weren't commented in the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah! makes sense.
(it's a shame that whoever added the -p
flag to col
didn't also strip escape sequences)
@plttn It seems that the |
Few things here:
Personal bugbear that isn't a huge deal:
With concurrent mode on, the preview looks like this:
With concurrent off, it looks like this:
I couldn't quite figure out how to get grep to drop those first few lines, but feel free to amend the PR if you can get it sorted.