Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow ctest to run from the top level build #126

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

allow ctest to run from the top level build #126

wants to merge 1 commit into from

Conversation

cwpearson
Copy link
Collaborator

No description provided.

dssgabriel
dssgabriel approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@dssgabriel dssgabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't realize my changes would break this! Feel free to remove the comments if this should be obvious.

Also, does this change allow us to remove the enable_testing() calls that are in the CMake files of the test directories?

@janciesko
Copy link
Collaborator

This does not work for me. Should this work?

$pwd
/ascldap/users/jciesko/RAndD/kokkos-comm
$ctest -j 3
Test project /ascldap/users/jciesko/RAndD/kokkos-comm
No tests were found!!!

How do you all feel about set(CMAKE_DISABLE_IN_SOURCE_BUILD ON)?

@janciesko janciesko self-requested a review October 8, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dssgabriel dssgabriel dssgabriel approved these changes

@janciesko janciesko Awaiting requested review from janciesko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwpearson @janciesko @dssgabriel