Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mdspan support #26

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Remove mdspan support #26

merged 1 commit into from
Apr 10, 2024

Conversation

masterleinad
Copy link
Collaborator

Fixes #25. We discussed that we don't want mdspan support for now.

cedricchevalier19
cedricchevalier19 reviewed Apr 9, 2024
View reviewed changes
Copy link
Member

@cedricchevalier19 cedricchevalier19 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favour of this PR as it will remove the burden to maintain a long term and experimental feature.

For research experiments, one can restore the previous code (that is a good starting point for mdspan) from git.

@masterleinad masterleinad marked this pull request as ready for review April 9, 2024 21:25
cedricchevalier19
cedricchevalier19 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@cedricchevalier19 cedricchevalier19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let @cwpearson do the merge if he agrees.

@cedricchevalier19 cedricchevalier19 mentioned this pull request Apr 10, 2024
Closed
@cwpearson
Copy link
Collaborator

Thanks for this!

@cwpearson cwpearson merged commit d35dc30 into kokkos:develop Apr 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedricchevalier19 cedricchevalier19 cedricchevalier19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mdspan support when Kokkos already has one
3 participants
@masterleinad @cwpearson @cedricchevalier19