Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpi: 1D contiguous alltoall in Impl #54

Merged
merged 1 commit into from
May 17, 2024

Conversation

cwpearson
Copy link
Collaborator

@cwpearson cwpearson commented May 10, 2024

Just in Impl:: for now

@cwpearson
Copy link
Collaborator Author

Needs documentation

@aprokop
Copy link
Contributor

aprokop commented May 11, 2024

Needs MPI_IN_PLACE version.

@cwpearson
Copy link
Collaborator Author

Okay we have an in-place version too now

@cwpearson cwpearson marked this pull request as ready for review May 13, 2024 15:56
Copy link
Member

@cedricchevalier19 cedricchevalier19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion for getting rid of % operator.

src/impl/KokkosComm_alltoall.hpp Show resolved Hide resolved
unit_tests/test_alltoall.cpp Show resolved Hide resolved
unit_tests/test_alltoall.cpp Show resolved Hide resolved
@cwpearson cwpearson merged commit 4223662 into kokkos:develop May 17, 2024
6 checks passed
@cwpearson cwpearson deleted the mpi/alltoall branch May 17, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants