Add General CMake Build Option #588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
reviewed
Oct 4, 2024
| @@ -160,6 +160,10 @@ General options | |||
| * Aggressively vectorize loops | |||
| * ``OFF`` | |||
|
|
|||
| * * ``Kokkos_ENABLE_COMPILE_AS_CMAKE_LANGUAGE`` | |||
| * Analogous to CUDA/HIP as CMake language | |||
There was a problem hiding this comment.
The doc string in CMake is
Suggested change
| * Analogous to CUDA/HIP as CMake language | |
| * Whether to use native cmake language support |
There was a problem hiding this comment.
Sounds good, but I deviated somewhat from your suggestion. The "use native CMake ..." is the more general, so I put it ahead of the other statement.
|
https://github.com/kokkos/kokkos-core-wiki/pull/555/files is the more comprehensive pull request. Can you instead comment there? |
|
Superseded by #555. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing adding CMake build option (
Kokkos_ENABLE_COMPILE_AS_CMAKE_LANGUAGE) to the list of general options