Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Kokkos_Profiling_[C_]Interface.* #260

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Update Kokkos_Profiling_[C_]Interface.* #260

merged 1 commit into from
Jul 8, 2024

Conversation

masterleinad
Copy link
Contributor

This needs to match the respective Kokkos files so that the device id can be correctly parsed.

dalg24
dalg24 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm what Kokkos version you are snapshotting.
Do you know what the current version corresponded to?

@masterleinad
Copy link
Contributor Author

Please confirm what Kokkos version you are snapshotting.

develop but the files haven't changed since the last release except for adding extern "C".

Do you know what the current version corresponded to?

kokkos/kokkos@b9c7ba8 so Kokkos 3.1.00 and this version is basically from kokkos/kokkos@d9170c0 so Kokkos 3.6.00

@dalg24 dalg24 merged commit 9c317a5 into kokkos:develop Jul 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masterleinad @dalg24