Rebase cuda-11.0 with kokkos-tools develop #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting in tool_invoked_fence code.
Fixing tool induced fences to always fence on device with DevID 0. Fencing with DevID will be a done in subsequent patch (where Pair object will be used in the hash table to capture the begin sample's information. Note that the pair/tuple object can capture other state information to store between the beginning of sampling event and ending of it.
for infokIDSample efficiency in space
…tools into fenceOnSampleOnly
kp_sampler_skip.cpp: erase for efficiency of unordered map
Passing devID to invoke_ktools_febce() instead of 0 is in a separate PR. Checking fence is done only on devID hasn't been tested in this PR and isn't directly related to this PR.
Fence on sample only
* :Use eventset for roctxconnector * Improvements thanks to review.
type: renaming `Kokkos_Tools_OptimizationGoal`
papi(bug): use `kp_add_library` to ensure it is installed
Don't disable clang-format in kp_json_writer.cpp
Use different GitHub action for indentation check
cleaning(simple-kernel-timer): promote `find_index` to `kp_shared.hpp`
* Add header/legend line to kp_reader describing what each column means * formatting * Add a space to header, matching region/kernel lines
Sampler's CMakeLists.txt: add_library to kp_add_library
kp_sampler_skip.cpp: last parameter should be passed by value rather than pointer in kokkosp_p_t_p_i
Use kokkos tools kp_add_library for sampler
Remove tool programming interface pointer in kp_sampler_skip.cpp and kp_core.hpp
kp_kernel_logger.cpp: typo in end scan call back function
* README.md: fix build/run instructions Fix build and run instructions, put information at the top. * README.md: fix install dir, revert unrelated changes * Update README.md Co-authored-by: Daniel Arndt <[email protected]> * Update README.md: remove output file mention Co-authored-by: Daniel Arndt <[email protected]> * Update README.md Co-authored-by: Daniel Arndt <[email protected]> --------- Co-authored-by: Daniel Arndt <[email protected]> Co-authored-by: Christian Trott <[email protected]>
…n corner case) (#253) * kp_sampler_skip.cpp: put begin for callee check before fence This improves performance in the case there is no callee for the kokkosp_begin_parallel_for. This is actually done correctly in the kokkosp_begin_parallel_scan and begin_parallel_reduce. * kp_sampler_skip.cpp: apply clang-format
Fix line endings
This PR introduces probabilistic sampling into kokkos_sampler, enabling the avoidance of bias in the sampled operations. Two new options are introduced: KOKKOS_TOOLS_SAMPLER_PROB and KOKKOS_TOOLS_RANDOM_SEED which set the rate and a random seed respectively. The PR also introduces tests.
Don't link against kokkostools in tests unconditionally
…mode Remove KOKKOSTOOLS_LIBRARY_MODE
kp_space_time_stack.cpp: do null pointer check of ptr at the beginning of alloc and dealloc functions
Check for de/allocations pointing to null
Fix finding Variorum via environment variable
…erface Update Kokkos_Profiling_[C_]Interface.*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rebases cuda-11.0 branch (for a new CI) with develop